Skip to content

Carbon v3 #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Carbon v3 #299

merged 3 commits into from
Feb 1, 2024

Conversation

driesvints
Copy link
Member

No description provided.

@driesvints driesvints marked this pull request as ready for review January 29, 2024 16:09
@driesvints driesvints requested a review from nunomaduro January 29, 2024 16:09
@timacdonald timacdonald marked this pull request as draft January 29, 2024 20:59
@timacdonald
Copy link
Member

Pushed a fix to maintain the int value returned from diffInMilliseconds. This return type changed in Carbon v3.

Although not a major issue, it is a potential change in functionality if the config were to contain a float value.

@timacdonald timacdonald marked this pull request as ready for review January 29, 2024 21:43
@timacdonald timacdonald marked this pull request as draft January 29, 2024 21:47
@timacdonald
Copy link
Member

I would prefer to keep this in draft until v3 is actually released and we know for sure what all the breaking changes are.

Otherwise we merge this and they tag additional breaking changes in future beta release and we have to re-review.

@driesvints
Copy link
Member Author

@timacdonald Should only be bug fixes from now on normally.

@driesvints driesvints marked this pull request as ready for review February 1, 2024 15:47
@driesvints
Copy link
Member Author

Stable release out now.

@taylorotwell taylorotwell merged commit 801ec40 into 1.x Feb 1, 2024
@taylorotwell taylorotwell deleted the carbon-v3 branch February 1, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants